[Webkit-unassigned] [Bug 236938] Python3 for lighttpd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236938

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 453304
  --> https://bugs.webkit.org/attachment.cgi?id=453304
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453304&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/http_server.py:-115
> -                 '               ".php"  => "%s" )\n\n') %
> -                                     self._port_obj._path_to_lighttpd_php())

Change log doesn’t mention why we’re removing ".php". Maybe a good idea, but why? Also, why not remove the _path_to_lighttpd_php function too?

> Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.conf:41
> -static-file.exclude-extensions = ( ".php", ".pl", ".cgi" )
> +static-file.exclude-extensions = ( ".py", ".pl", ".cgi" )

Same question: What’s the rationale for removing ".php"? Also, not great to leave the mention of it in the comment on the line above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220226/6f54f3b9/attachment.htm>