[Webkit-unassigned] [Bug 237170] [CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 18:12:46 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=237170

Stephan Szabo <stephan.szabo at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephan.szabo at sony.com

--- Comment #3 from Stephan Szabo <stephan.szabo at sony.com> ---
It seems like it'd work better if those were cache variables rather than normal ones if we're expecting them to have overwritten values from the command line that'll persist.

The others are using an if(NOT DEFINED XXX) block, which may also work if put around the set in WebKitCommon, but seems like it's just doing the same sort of thing that a cache variable would already do. Is there some piece of the cache variable behavior that's problematic for what we're doing (for example maybe around the HAS_RUN_WEBKIT_COMMON bits?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220225/ea9a3ff7/attachment.htm>


More information about the webkit-unassigned mailing list