[Webkit-unassigned] [Bug 237170] [CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 24 17:42:59 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=237170

--- Comment #1 from Basuke Suzuki <Basuke.Suzuki at sony.com> ---
This change seems working as I expected, but I'm not sure this is the correct direction.

diff --git a/Source/cmake/WebKitCommon.cmake b/Source/cmake/WebKitCommon.cmake
index e58c7069abb1..c3389c8e46f7 100644
--- a/Source/cmake/WebKitCommon.cmake
+++ b/Source/cmake/WebKitCommon.cmake
@@ -13,19 +13,19 @@ if (NOT HAS_RUN_WEBKIT_COMMON)
         message(STATUS "The CMake build type is: ${CMAKE_BUILD_TYPE}")
     endif ()

-    set(ENABLE_JAVASCRIPTCORE ON)
-    set(ENABLE_WEBCORE ON)
+    set(ENABLE_JAVASCRIPTCORE ON CACHE STRING "Enable JavaScriptCore build")
+    set(ENABLE_WEBCORE ON ON CACHE STRING "Enable WebCore build")

     if (NOT DEFINED ENABLE_WEBKIT)
-        set(ENABLE_WEBKIT ON)
+        set(ENABLE_WEBKIT ON ON CACHE STRING "Enable WebKit build")
     endif ()

     if (NOT DEFINED ENABLE_TOOLS AND EXISTS "${CMAKE_SOURCE_DIR}/Tools")
-        set(ENABLE_TOOLS ON)
+        set(ENABLE_TOOLS ON ON CACHE STRING "Enable Tools build")
     endif ()

     if (NOT DEFINED ENABLE_WEBINSPECTORUI)
-        set(ENABLE_WEBINSPECTORUI ON)
+        set(ENABLE_WEBINSPECTORUI ON ON CACHE STRING "Enable WebInspector UI build")
     endif ()

     # -----------------------------------------------------------------------------

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220225/c52c9098/attachment-0001.htm>


More information about the webkit-unassigned mailing list