[Webkit-unassigned] [Bug 237060] Queue throwing exception of blob objects during destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237060

--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 452903
  --> https://bugs.webkit.org/attachment.cgi?id=452903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452903&action=review

>> Source/WebCore/fileapi/Blob.cpp:284
>> +            // will be performing a sweep at that time.
> 
> This is not quite correct.  Let's replace this with:
> 
> "This function can be called doing Blob destruction, which in turn is called by GC sweep.  Since we cannot allocated objects while sweeping, we need to defer the call to error() which will allocate an exception object, by queueing a task.  Additionally, if this is being called during VM shut down, the task queue may already destructed.  So, we will skip the enqueuing of this task if we're in the midst of VM shut down."

Hmmm, I wrote this blurb before the one in the ChangeLog.  I think the ChangeLog one is more concise (and doesn't run on).  Maybe just use that here instead?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220222/d00202d3/attachment.htm>