[Webkit-unassigned] [Bug 237060] Queue throwing exception of blob objects during destruction

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237060

Alexey Shvayka <ashvayka at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ashvayka at apple.com

--- Comment #2 from Alexey Shvayka <ashvayka at apple.com> ---
Comment on attachment 452903
  --> https://bugs.webkit.org/attachment.cgi?id=452903
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452903&action=review

> Source/WebCore/bindings/js/ReadableStreamDefaultController.h:50
> +    JSDOMGlobalObject& getGlobalObject() const 

Per WebKit code style guidelines, this should be named just "globalObject".

> Source/WebCore/fileapi/Blob.cpp:291
> +                context->eventLoop().queueTask(TaskSource::InternalAsyncTask, [this, code] {

Should we also pass `protectedThis = Ref { *this }`?

> Source/WebCore/fileapi/FileReaderLoader.h:92
> +    ScriptExecutionContext* getScriptExecutionContext() const { return m_scriptExecutionContext; }

Ditto: "scriptExecutionContext".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220222/80edd686/attachment-0001.htm>