[Webkit-unassigned] [Bug 237056] New: git-webkit pr tried to create another commit from local changes on current branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=237056

            Bug ID: 237056
           Summary: git-webkit pr tried to create another commit from
                    local changes on current branch
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: aakash_jain at apple.com

I was on a branch, made a commit to it. I also had some local changes in other files. When I run git-webkit pr command, it automatically tried to create another commit from local changes. This might be unexpected for users, especially when they explicitly committed what they wanted to commit/push. Coupled with the fact that git-webkit pr doesn't show any preview before creating the PR, this might not be a good idea.

git-webkit pr shouldn't try to automatically commit local changes when user is on a branch and there is already a commit by the user on that branch. Either errroring out or asking the user if he/she wants to create a commit from local changes is better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220222/ed4f82ad/attachment.htm>