[Webkit-unassigned] [Bug 236952] Permission API: handle non-fully active documents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236952

youenn fablet <youennf at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #452832|review?                     |review+
              Flags|                            |

--- Comment #10 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 452832
  --> https://bugs.webkit.org/attachment.cgi?id=452832
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452832&action=review

> Source/WebCore/Modules/permissions/PermissionStatus.cpp:72
> +    auto* context = scriptExecutionContext();

Not really needed

> Source/WebCore/Modules/permissions/PermissionStatus.cpp:73
> +    if (auto document = dynamicDowncast<Document>(context); !document->isFullyActive())

I would use auto* to match Permissions::query.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220222/dddf69ad/attachment.htm>