[Webkit-unassigned] [Bug 236995] Use ArgumentParser for parsing args in generate-compile-commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236995

--- Comment #3 from Elliott Williams <emw at apple.com> ---
LGTM!

(In reply to Alexey Proskuryakov from comment #2)
> 
> > Tools/Scripts/generate-compile-commands:40
> > +parser.add_argument('built_products_dir', help='path to the build directory containing generated compile commands (ex: WebKitBuild/Release)')
> 
> This seems like it should be required=True

Positional arguments are `required` by default, so it should be fine as-is.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220222/94e1b7d7/attachment.htm>