[Webkit-unassigned] [Bug 235686] Generate compile_commands.json on macOS Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235686

Elliott Williams <emw at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #451810|                            |review-
              Flags|                            |

--- Comment #21 from Elliott Williams <emw at apple.com> ---
Comment on attachment 451810
  --> https://bugs.webkit.org/attachment.cgi?id=451810
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451810&action=review

This is relevant to each project's DebugRelease.xcconfig changes:

> PerformanceTests/DecoderTest/Configurations/DebugRelease.xcconfig:41
> +OTHER_CFLAGS = $(COMPILE_COMMANDS_$(EXPORT_COMPILE_COMMANDS));
> +OTHER_CPLUSPLUSFLAGS = $(COMPILE_COMMANDS_$(EXPORT_COMPILE_COMMANDS));
> +COMPILE_COMMANDS_ = $(inherited);
> +COMPILE_COMMANDS_YES = $(inherited) "-gen-cdb-fragment-path" '$(BUILT_PRODUCTS_DIR)/compile_commands';

- I think OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS need an $(inherited), to pick up settings defined in each project's Base.xcconfig. This may be why you're seeing other compiler flags get clobbered.
- The COMPILE_COMMANDS_* variables shouldn't need to use $(inherited).  There aren't lower layers of build settings setting which define the COMPILE_COMMANDS variables, so it doesn't seem like it would ever expand to anything. 
- You should only need to set OTHER_CFLAGS. I believe that Xcode passes that setting to clang in C _and_ C++ modes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220217/0681e88f/attachment-0001.htm>