[Webkit-unassigned] [Bug 236683] [XCBuild] Use native build phases to copy PAL's headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236683

--- Comment #5 from Elliott Williams <emw at apple.com> ---
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 452143 [details]
> Native PAL Headers via build rules v2
> 
> Supporting two different code paths until we completely drop the legacy
> build system support seems potentially troublesome. I did not think through
> this patch enough to have a feel of how likely it is to break the build in
> just one build system when making changes.

Agreed, I don't like it either. This codepath will be tested in production builds which use XCBuild, and by the builds.webkit.org bot we are setting up in https://bugs.webkit.org/show_bug.cgi?id=236726.

An alternative approach I tried was to have the legacy build system copy to a flattened directory (/usr/local/include/pal_flattened), and then have a script go through and "nest" those headers back to their proper hierarchy. It's still quite a bit different from the XCBuild code path, but does ensure that all the headers PAL is using are part of Headers phase. I'll put that patch up too and we can decide which is best.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220216/f1de93aa/attachment.htm>