[Webkit-unassigned] [Bug 236654] [EWS] Support PRs when sending layout test failure emails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236654

--- Comment #5 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Jonathan Bedard from comment #3)
> > Landed 247326 at main (r289888)
> 
> there are a few issues with this patch:
> 
> a few _addToLog() calls miss the two parameters needed and there is one
> variable undefined.
> 
> I detected this meanwhile working on bug 236705 which adds unit tests to
> test the send_email() calls
> 
> This would be the fix: http://sprunge.us/BNhsG4
> 
> I can include it as part of bug 236705

I landed 289947 that includes also those fixes.

Now the unit tests exercise the code for the send_email_* functions so this should be easier to detect in the future

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220216/596040c7/attachment.htm>