[Webkit-unassigned] [Bug 229780] Fixes for build-webkit --minimal

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=229780

--- Comment #33 from Philip Chimento <philip.chimento at gmail.com> ---
(In reply to Don Olmstead from comment #31)
> > Source/WebCore/html/ColorInputType.cpp:42
> > +#include "ElementChildIterator.h"
> 
> This still valid? I don't see that referenced in this cpp?

childrenOfType<...> is used in several places, so this is still valid.

> > Source/WebCore/inspector/agents/InspectorCanvasAgent.h:29
> > +#include "Frame.h"
> 
> There's already a forward declaration of Frame here.
> 
> > Source/WebCore/inspector/agents/InspectorNetworkAgent.h:37
> > +#include "SharedBuffer.h"
> 
> This looks like it can be forward declared.

Both of these removed, they don't seem to be necessary anymore. I also had to add another missing include of <wtf/text/WTFString.h> elsewhere.

This does not quite fix --minimal altogether. I still have to switch on ENABLE_CONTEXT_MENUS, ENABLE_POINTER_LOCK, ENABLE_MHTML, ENABLE_CONTENT_EXTENSIONS, ENABLE_INTELLIGENT_TRACKING_PREVENTION, and ENABLE_INPUT_TYPE_COLOR because there is a lot of code in the GLib portions that assumes these will be enabled. If I were to add guards around those, they would quickly overwhelm everything else in this patch, but I'm prepared to leave that for another patch if that's OK.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220215/f9981ced/attachment.htm>