[Webkit-unassigned] [Bug 232936] [GTK] When building introspection files, add CMAKE_C_FLAGS to the compiler flags.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=232936

Adrian Perez <aperez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aperez at igalia.com

--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 443793
  --> https://bugs.webkit.org/attachment.cgi?id=443793
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443793&action=review

>> Source/JavaScriptCore/PlatformGTK.cmake:74
>> +        COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} LDFLAGS=
> 
> Can you write it without a backslash as CFLAGS="-Wno-deprecated-declarations ${CMAKE_C_FLAGS}"?

Should work without the backslash, yup. Here it is harmless because escaping a space
character in the shell results in a space character ("\ " → " ") but it would be
nicer to remove it, for clarity.

> Source/WebKit/PlatformGTK.cmake:677
> +        COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS} LDFLAGS=

Same issue here with the backslash.

> Source/WebKit/PlatformGTK.cmake:723
> +        COMMAND CC=${CMAKE_C_COMPILER} CFLAGS=-Wno-deprecated-declarations\ ${CMAKE_C_FLAGS}

...and here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220215/0ffff03e/attachment-0001.htm>