[Webkit-unassigned] [Bug 236514] Add check to ensure we limit the number of expansionOpportunities

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 16:10:36 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=236514

--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 451716
  --> https://bugs.webkit.org/attachment.cgi?id=451716
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451716&action=review

> Source/WebCore/rendering/LegacyLineLayout.cpp:571
> +    for (auto* leafChild = rootBox.firstLeafDescendant(); leafChild && i < expansionOpportunities.size(); leafChild = leafChild->nextLeafOnLine()) {

I think this is a band-aid fix. It's not harmful, but it doesn't solve the underlying problem that the invariant is being violated. (The invariant is expansionOpportunities.size() == number of leaves on line.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220212/32d23de7/attachment.htm>


More information about the webkit-unassigned mailing list