[Webkit-unassigned] [Bug 229780] Fixes for build-webkit --minimal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 11 15:23:46 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=229780

Don Olmstead <don.olmstead at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |don.olmstead at sony.com
 Attachment #451742|review?                     |review+
              Flags|                            |

--- Comment #31 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 451742
  --> https://bugs.webkit.org/attachment.cgi?id=451742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451742&action=review

r=me with nits. Honestly you might want to do a non-unified with the minimal build as well.

> Source/WebCore/html/ColorInputType.cpp:42
> +#include "ElementChildIterator.h"

This still valid? I don't see that referenced in this cpp?

> Source/WebCore/inspector/agents/InspectorCanvasAgent.h:29
> +#include "Frame.h"

There's already a forward declaration of Frame here.

> Source/WebCore/inspector/agents/InspectorNetworkAgent.h:37
> +#include "SharedBuffer.h"

This looks like it can be forward declared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220211/2b25b8a6/attachment.htm>


More information about the webkit-unassigned mailing list