[Webkit-unassigned] [Bug 236518] Redirect shadow realm console output to page's ConsoleClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236518

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #451743|review?                     |review+
              Flags|                            |

--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 451743
  --> https://bugs.webkit.org/attachment.cgi?id=451743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451743&action=review

r=mews, thanks for taking my suggestions! =D

> LayoutTests/inspector/shadow-realm-console.html:26
> +            async test(resolve, reject) {

NIT: please remove the `resolve, reject` since those are not provided when using an `async test` :)

> LayoutTests/inspector/shadow-realm-console.html:40
> +            async test(resolve, reject) {

ditto (:26)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220211/038c77d5/attachment.htm>