[Webkit-unassigned] [Bug 233018] WebKit should pipe mouse hover events on iOS to the UI delegate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=233018

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #451480|review?                     |review+
              Flags|                            |

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 451480
  --> https://bugs.webkit.org/attachment.cgi?id=451480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451480&action=review

> Source/WebKit/Shared/API/Cocoa/_WKHitTestResult.h:28
> +#if TARGET_OS_OSX || TARGET_OS_IPHONE

I'm pretty sure this condition is true everywhere that this file exists (IPHONE includes all of the iOS-derivatives), so maybe you can just delete it instead? Or maybe you meant TARGET_OS_IOS

> Source/WebKit/UIProcess/Cocoa/UIDelegate.mm:74
> +#if !PLATFORM(MAC)

Why the inverted condition? Should be PLATFORM(IOS_FAMILY) or maybe the HAVE

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220210/c120657d/attachment.htm>