[Webkit-unassigned] [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235744

Elliott Williams <emw at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #451329|0                           |1
        is obsolete|                            |
 Attachment #451330|0                           |1
        is obsolete|                            |
 Attachment #451472|                            |review?
              Flags|                            |

--- Comment #29 from Elliott Williams <emw at apple.com> ---
Created attachment 451472

  --> https://bugs.webkit.org/attachment.cgi?id=451472&action=review

Add untracked WTF headers to WTF.xcodeproj

Third time's a charm? Relanding.

I made a debug builds for Mac, iOS, and iOS Simulator, comparing the contents of /usr/local/include/wtf for this patch and trunk. I found some headers which were never added to WTF.xcodeproj. This patch adds:

        wtf/DataMutex.h
        wtf/MainThreadData.h
        wtf/NullTextBreakIterator.h
        wtf/ParallelJobsGeneric.h
        wtf/ParallelJobsOpenMP.h
        wtf/PlatformEnablePlayStation.h
        wtf/text/NullTextBreakIterator.h
        wtf/UniStdExtras.h
        wtf/WindowsExtras.h

There are some headers which were previously being copied that I am still excluding, because they _should_ only be used on non-Apple platforms. Everything from these directories remains untracked:

        wtf/glib
        wtf/linux
        wtf/text/win
        wtf/win

Since EWS has proven untrustworthy, I've made clean Debug builds with an internal SDK to confirm. It'd probably be wise to do a clean build with an external SDK, too. Open to other testing ideas if you have them.

--

> I don't understand why EWS was green.
My theory is that since EWS does not clean between builds, builders might have old headers in /usr/local/include from previous builds. I'm not sure why those stale headers are eventually getting cleaned out, though -- without cleaning between builds, how does EWS handle _any_ build product deletion?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220210/9e38e4da/attachment.htm>