[Webkit-unassigned] [Bug 236265] Return 'none' as the computed style for mask when there are no images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236265

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 451210
  --> https://bugs.webkit.org/attachment.cgi?id=451210
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451210&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.h:99
> -    Ref<CSSValueList> getFillLayerPropertyShorthandValue(CSSPropertyID, const StylePropertyShorthand& propertiesBeforeSlashSeparator, const StylePropertyShorthand& propertiesAfterSlashSeparator, CSSPropertyID lastLayerProperty);
> -    Ref<CSSValueList> getBackgroundShorthandValue();
> -    Ref<CSSValueList> getMaskShorthandValue();
> +    RefPtr<CSSValue> getFillLayerPropertyShorthandValue(CSSPropertyID, const StylePropertyShorthand& propertiesBeforeSlashSeparator, const StylePropertyShorthand& propertiesAfterSlashSeparator, CSSPropertyID lastLayerProperty);
> +    RefPtr<CSSValue> getBackgroundShorthandValue();
> +    RefPtr<CSSValue> getMaskShorthandValue();

Why the change from Ref to RefPtr? These can’t return nullptr, can they?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220208/08082c71/attachment.htm>