[Webkit-unassigned] [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 7 18:55:13 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=236054

--- Comment #17 from Matt Woodrow <mattwoodrow at apple.com> ---
(In reply to Oriol Brufau from comment #15)
> > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1060
> > +        if (!repeatCollector.namedGridLineCount()) {
> 
> I still think this condition is a bit loose.
> 
>   document.body.style.gridTemplateRows = "subgrid repeat(auto-fill, [])";
>   getComputedStyle(document.body).gridTemplateRows;
>   // Firefox: "subgrid repeat(auto-fill, [])"
>   // WebKit: "subgrid"

Good catch, the test I added only checked serialised style, not computed.

I've added a few new tests (all variations of [] were broken).


> > Source/WebCore/rendering/style/StyleGridData.h:107
> > +    bool subgridColumns;
> 
> May be done in another patch, but I guess that GridTemplateTracksWrapper in
> CSSPropertyAnimation.cpp should check these.

Indeed, I haven't tried to handle animation in this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220208/7a9bb479/attachment.htm>


More information about the webkit-unassigned mailing list