[Webkit-unassigned] [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236054

--- Comment #15 from Oriol Brufau <obrufau at igalia.com> ---
Comment on attachment 451158
  --> https://bugs.webkit.org/attachment.cgi?id=451158
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=451158&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1060
> +        if (!repeatCollector.namedGridLineCount()) {

I still think this condition is a bit loose.

  document.body.style.gridTemplateRows = "subgrid repeat(auto-fill, [])";
  getComputedStyle(document.body).gridTemplateRows;
  // Firefox: "subgrid repeat(auto-fill, [])"
  // WebKit: "subgrid"

> Source/WebCore/css/parser/CSSPropertyParser.cpp:3702
> +    while (!args.atEnd()) {

This could be a do...while to avoid repeating the code.

> Source/WebCore/rendering/style/StyleGridData.h:107
> +    bool subgridColumns;

May be done in another patch, but I guess that GridTemplateTracksWrapper in CSSPropertyAnimation.cpp should check these.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220208/1c4712b0/attachment.htm>