[Webkit-unassigned] [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236054

--- Comment #13 from Matt Woodrow <mattwoodrow at apple.com> ---
(In reply to Oriol Brufau from comment #10)
> 
> > Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1059
> > +    if (isSubgrid ? !repeatCollector.namedGridLineCount() : autoRepeatTrackSizes.isEmpty()) {
> 
> I don't think !repeatCollector.namedGridLineCount() is the right condition.
> `subgrid repeat(auto-fill, [])` has 0 lines but should not be handled here.
> And if there is no WPT for this, please add one.

I think this would count as having one line, but zero actual names assigned to that line.

I've added a WPT to check this, and the duplicated auto repeat case.

Thanks for the review!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220207/df46533f/attachment.htm>