[Webkit-unassigned] [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235744

--- Comment #19 from Alexey Proskuryakov <ap at webkit.org> ---
> - Failing the build when the xcfilelists _do_ change, so it's not possible
> for the files to silently get mutated on a CI machine. 

I do not understand why mutating in CI is impossible. Don't our scripts mutate the source xcfilelists before failing the build?

> - Checking (and potentially regenerating) xcfilelists in every build, so
> that regenerations are caught early.

What are the configurations where we check xcfilelists? I thought that this was disabled in many places.

> In the status quo, it's possible to send a patch to EWS that regenerates
> xcfilelists, but that would mean you had _never_ completed a build at your
> desk first. I'm guessing that doesn't happen often, which is why we don't
> regularly see source conflicts on CI machines.

This explanation seems unlikely to me. People who work on non-Mac platforms would not be building with Xcode at all before EWS. And those who do wouldn't build for all platforms, which can well have different inputs and outputs due to different features being enabled.

Perhaps subtle reasons like these are why we aren't hitting problems all the time, but this means that we are walking a very thin line.

> Does that sound reasonable, or do you think I should abandon this and
> instead land the native build phase approach from the first patch?

I still don't feel like I understand the situation enough to confidently suggest what's right. The first patch feels safer at this point FWIW.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220205/534b967d/attachment.htm>