[Webkit-unassigned] [Bug 234578] Grid may be empty in certain scenarios

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 4 12:58:20 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=234578

--- Comment #21 from Brandon <brandonstewart at apple.com> ---
(In reply to Darin Adler from comment #18)
> Comment on attachment 450834 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450834&action=review
> 
> > Source/WebCore/rendering/RenderGrid.h:194
> > +    void computeAspectRatioDependantAndBaselineItems(Vector<RenderBox*>& aspectRatioBlockSizeDependentGridItems);
> 
> This should use a return value rather than an out argument.
> 
> Also, "dependent" is misspelled here.

Updated the function to return the grid items and addressed the spelling mistake.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220204/e2130053/attachment-0001.htm>


More information about the webkit-unassigned mailing list