[Webkit-unassigned] [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236054

--- Comment #7 from Darin Adler <darin at apple.com> ---
(In reply to Matt Woodrow from comment #5)
> It looks like we have one of these for every initial value, even though
> they're all only used in one place.

That’s not right. The first one I checked was initialStrokeMiterLimit, and I found it was used in four places, importantly one of those places was in generated code. I now realize that the primary reason these exist are for that generated code, in StyleBuilderGenerated.cpp, generated from CSSProperties.json by the makeprop script.

> I did the same for this just to keep in sync with the surrounding code, but
> I don't have any attachment to doing it this way.

I think it’s possible you misunderstood the existing pattern. I think the new function in this patch doesn’t match the naming pattern well enough to work for the generated code. I think we should only follow that pattern if this new code is participating in the CSSProperties.json mechanism.

> Do you want me to fix all the members here, or just make the new one correct
> for now? I just matched the surrounding style.

I would suggest making the new one correct even though that is inconsistent. And as a contribution to the health of the project, follow through afterward with a patch to fix the rest.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220203/1bca204c/attachment.htm>