[Webkit-unassigned] [Bug 236054] Add support for parsing 'subgrid' in grid-template-columns/row

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=236054

--- Comment #5 from Matt Woodrow <mattwoodrow at apple.com> ---
(In reply to Darin Adler from comment #3)
> > Source/WebCore/rendering/style/RenderStyle.h:1775
> > +    static bool initialGridSubgrid() { return false; }
> 
> Why go the trouble of using a function here. It only share one for rows and
> columns?
> 
> > Source/WebCore/rendering/style/StyleGridData.h:106
> > +    bool subgridRows;
> 
> Can we just initialize to false here instead of using the cumbersome
> RenderStyle approach?

It looks like we have one of these for every initial value, even though they're all only used in one place.

I did the same for this just to keep in sync with the surrounding code, but I don't have any attachment to doing it this way.

> 
> > Source/WebCore/style/StyleBuilderConverter.h:1007
> > +    bool m_isSubgrid { false };
> 
> This whole struct uses incorrect coding style. Public struct members should
> not have m_ prefixes.

Do you want me to fix all the members here, or just make the new one correct for now? I just matched the surrounding style.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220203/44b7ce1c/attachment.htm>