[Webkit-unassigned] [Bug 235744] [XCBuild] WTF's headers are copied via a script and are invisible to the build system

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235744

--- Comment #15 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 450590
  --> https://bugs.webkit.org/attachment.cgi?id=450590
Generate xcfilelists for rsync r3

View in context: https://bugs.webkit.org/attachment.cgi?id=450590&action=review

I'm curious if this in particular would be a good fit for pre-build action.

> Source/WTF/Scripts/copy-wtf-headers.sh:14
> +if [[ "${DEPLOYMENT_LOCATION}" == "NO" ]]; then
> +    PRIVATE_HEADERS_PATH="${TARGET_BUILD_DIR%/}/${PRIVATE_HEADERS_FOLDER_PATH}"
> +    ICU_PRIVATE_HEADERS_PATH="${TARGET_BUILD_DIR%/}/${ICU_PRIVATE_HEADERS_FOLDER_PATH}"
> +else
> +    PRIVATE_HEADERS_PATH="${DSTROOT}/${PRIVATE_HEADERS_FOLDER_PATH}"
> +    ICU_PRIVATE_HEADERS_PATH="${DSTROOT}/${ICU_PRIVATE_HEADERS_FOLDER_PATH}"
> +fi;

This makes me wonder if we'll generate different xcfilelists between these cases.

> Source/WTF/WTF.xcodeproj/project.pbxproj:1745
> +				"$(SRCROOT)/CopyWTFHeaders-Scripts-output.xcfilelist",
> +				"$(SRCROOT)/CopyWTFHeaders-wtf-output.xcfilelist",

Modifying source is sad. I understand that we have precedent, but I'd like to understand more about why it's OK - why we can never encounter read-only source, and why this won't cause SCM conflicts on bots as local changes clash with checkouts.

> Source/WTF/WTF.xcodeproj/project.pbxproj:1751
> +			shellScript = "set -eo pipefail\nScripts/copy-wtf-headers.sh\n";

"set -eo pipefail" isn't necessary here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220203/d3711cee/attachment.htm>