[Webkit-unassigned] [Bug 235751] [XCBuild] Add headers-only dependencies to projects in Tools/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235751

--- Comment #8 from Elliott Williams <emw at apple.com> ---
Sorry for the delay here. I took a fresh look at this, and split the gtest headers fix out to a separate bug: https://bugs.webkit.org/show_bug.cgi?id=236045

Hopefully the description there (and the greatly simplified patch) helps answer some of your questions.

(In reply to Alexey Proskuryakov from comment #7)
> > Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:125
> > +EXCLUDED_SOURCE_FILE_NAMES = $(EXCLUDED_PRODUCT_DEPENDENCY_NAMES_$(WK_WHICH_BUILD_SYSTEM));
> > +EXCLUDED_PRODUCT_DEPENDENCY_NAMES_legacy = WebKit.framework;
> 
> This is inherited in DumpRenderTreeLibrary.xcconfig, but I'm not sure about
> other xcconfigs:
> 
> DumpRenderTree.xcconfig, DumpRenderTreeApp.xcconfig and
> TestNetscapePlugIn.xcconfig have EXCLUDED_SOURCE_FILE_NAMES too, although
> conditional by SDK. Do they overwrite this? Ot does it not matter for some
> reason?

This setting was poorly organized on my part. It should only apply to DumpRenderTreeLibrary, which is why the override was not causing build failures. I'll move it to DumpRenderTreeLibrary.xcconfig in the next patch revision.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220203/aef56f99/attachment-0001.htm>