[Webkit-unassigned] [Bug 236045] New: [XCBuild] Users of libgtest.a depend on headers from gtest.framework

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 2 16:01:48 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=236045

            Bug ID: 236045
           Summary: [XCBuild] Users of libgtest.a depend on headers from
                    gtest.framework
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: emw at apple.com

In Make-based sequential builds, we always build gtest's dynamic target (gtest.framework). This target also builds the static library (libgtest.a) as a dependency, but only copies headers to the framework (i.e. `$SRCROOT/gtest/include` is copied to `$BUILT_PRODUCT_DIR/gtest.framework/Headers`). 

When a downstream project imports a gtest header, it finds it in the framework bundle.

The problem is that WebKit never actually links against gtest.framework. All our targets which use gtest link against the static library (libgtest.a). In workspace builds, Xcode sees this and only builds gtest's static target. Our surprise dependency on the _headers_ of gtest.framework is revealed as users of gtest fail to find its headers.

Fix by making gtest's static target also produce headers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220203/d3594a19/attachment-0001.htm>


More information about the webkit-unassigned mailing list