[Webkit-unassigned] [Bug 235686] Generate compile_commands.json on macOS Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235686

--- Comment #18 from Brandon <brandonstewart at apple.com> ---
(In reply to Saam Barati from comment #16)
> Comment on attachment 450587 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=450587&action=review
> 
> > Tools/ChangeLog:8
> > +        Add support to JavaScriptCore for generating compile_commands.json.
> 
> just JavaScriptCore?
> 

I didn't catch that mistake until after I posted it.
This supports all WebKit projects.

> > Tools/Scripts/generate-compile-commands.sh:35
> > +if ! [ -d /tmp/compile_commands/ ]; then
> 
> Why look in here? What if I have multiple builds happening simultaneously?
> Why isn't this just part of my Debug/Release build directory? That seems
> like the most logical place to put this stuff. Then this script can take an
> option for "--release" and "--debug", pick release or debug automatically if
> there is only one type of build.
> 

My method does not address multiple build scenarios well. Moving it back to the build directory would be more optimal. 

> > Tools/Scripts/generate-compile-commands.sh:61
> > +echo "Generated compile_commands.json"
> 
> can this print the path of where it gets generated? What're we doing for
> debug vs release?
> 

Sure.


> > Tools/Scripts/setup-compile-commands-configuration.sh:41
> > +echo "Succesfully generated Config files"
> > +echo "Configuration is stored in $(dirname "$0")/../../../LocalOverrides.xcconfig"
> 
> Is there nothing we can hook into with xcodebuild to automatically run
> generate-compile-commands.sh when we're done building? Maybe we should add
> an argument to "make"?

Adding support in make should definitely allows us to run the script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220202/f85bf5cd/attachment-0001.htm>