[Webkit-unassigned] [Bug 235925] [Modules] ES module link errors should be reported unmuted from script elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235925

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #450488|review?                     |review+
              Flags|                            |

--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 450488
  --> https://bugs.webkit.org/attachment.cgi?id=450488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450488&action=review

r=me

> Source/WebCore/bindings/js/ScriptController.cpp:215
> +        reportException(&lexicalGlobalObject, evaluationException, nullptr, /* fromModule */ true);

I recommend using a boolean variable here to name it.

constexpr bool fromModule = true;
reportException(&lexicalGlobalObject, evaluationException, nullptr, fromModule);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220202/467206ec/attachment-0001.htm>