[Webkit-unassigned] [Bug 235686] Generate compile_commands.json on macOS Builds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=235686

--- Comment #16 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 450587
  --> https://bugs.webkit.org/attachment.cgi?id=450587
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=450587&action=review

> Tools/ChangeLog:8
> +        Add support to JavaScriptCore for generating compile_commands.json.

just JavaScriptCore?

> Tools/Scripts/generate-compile-commands.sh:35
> +if ! [ -d /tmp/compile_commands/ ]; then

Why look in here? What if I have multiple builds happening simultaneously? Why isn't this just part of my Debug/Release build directory? That seems like the most logical place to put this stuff. Then this script can take an option for "--release" and "--debug", pick release or debug automatically if there is only one type of build.

> Tools/Scripts/generate-compile-commands.sh:61
> +echo "Generated compile_commands.json"

can this print the path of where it gets generated? What're we doing for debug vs release?

> Tools/Scripts/setup-compile-commands-configuration.sh:41
> +echo "Succesfully generated Config files"
> +echo "Configuration is stored in $(dirname "$0")/../../../LocalOverrides.xcconfig"

Is there nothing we can hook into with xcodebuild to automatically run generate-compile-commands.sh when we're done building? Maybe we should add an argument to "make"?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220202/45f7d82c/attachment.htm>