[Webkit-unassigned] [Bug 249272] [WPE][GTK] Robustly handle subprocess leaks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 22 05:17:53 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=249272

--- Comment #2 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Carlos Garcia had a suggestions at https://bugs.webkit.org/show_bug.cgi?id=247057#c10:

"""
I guess the process leaks started after 247678 at main, because now any process hang caused it to be leaked. Good thing is that now those hangs are noticeable, but leaking a process is by far worse. So, I think we should prevent the process leak even if that means we won't notice the hangs anymore (the one being debugged already would be great to fix though, I will move use a separate bug). The network process has a watchdog work queue to force a process exit after 10 seconds since the connection was closed. We could do the same for the web process.
"""

But I would enhance that a little: each auxiliary process should have a watchdog thread tied to its UI process connection, not just the web and network process.

We also need to figure out why we're leaking flatpak-spawn and bwrap and xdg-dbus-proxy processes. We seem to be leaking far more of these than we do auxiliary processes, which is weird. I would expect they're all designed to quit when the auxiliary process quits, but apparently something is wrong.

(And maybe we should talk more about https://commits.webkit.org/247678@main, because that should not be needed unless the kernel-level graphics driver is broken, and I'm really not convinced that WebKit upstream should care about such cases. Nothing userspace does should ever affect global kernel resources.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221222/3a3360e0/attachment.htm>


More information about the webkit-unassigned mailing list