[Webkit-unassigned] [Bug 249644] New: [Tools] built-product-archive shouldn't pass 'jsc' as port name for 'jsc-only'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=249644

            Bug ID: 249644
           Summary: [Tools] built-product-archive shouldn't pass 'jsc' as
                    port name for 'jsc-only'
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: clopez at igalia.com
                CC: bugs-noreply at webkitgtk.org
            Blocks: 249031

When the parameter platform=foo-bar is passed to the script built-product-archive the script picks as platform name 'foo'.

This is correct for platform names like ios-wk2 or mac-wk2 where the generic platform name is 'mac' or 'ios', but not for 'jsc-only'

This may causes issues later when calling the script webkit-build-directory to determine the build directory path.


Example of the issue (with the patch from bug 249604)

OK $ ./Tools/Scripts/webkit-build-directory --release --configuration --cross-target=rpi3-32bits-mesa --jsc-only
/home/clopez/webkit/webkit/WebKitBuild/JSCOnly/Release_rpi3-32bits-mesa


FAIL $ ./Tools/Scripts/webkit-build-directory --release --configuration --cross-target=rpi3-32bits-mesa --jsc
/home/clopez/webkit/webkit/WebKitBuild/Unknown/Release_rpi3-32bits-mesa

It prints 'Unknown' as port directory because 'jsc' is not a valid port name in webkitdirs.pm so passing --jsc here is like passing any random string

FAIL $ ./Tools/Scripts/webkit-build-directory --release --configuration --cross-target=rpi3-32bits-mesa --magicstring
/home/clopez/webkit/webkit/WebKitBuild/Unknown/Release_rpi3-32bits-mesa


The script webkit-build-directory doesn't complain when you pass an unknown command line switch, so passing '--jsc' is the same than passing '--magicstring' in this example.

The script build-webkit however complains, and if you pass '--jsc' instead of '--jsc-only' you get:

CMake Error at Source/cmake/WebKitCommon.cmake:57 (message):
  Please choose which WebKit port to build (one of
  AppleWin;Efl;FTW;GTK;JSCOnly;Mac;PlayStation;WPE;WinCairo)
Call Stack (most recent call first):
  CMakeLists.txt:25 (include)


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=249031
[Bug 249031] [META][WPE] Set-up performance bots with RPis and implement support in the WebKit tooling for automatic cross builds
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221220/7d9ce88c/attachment.htm>