[Webkit-unassigned] [Bug 249580] New: Evaluate string::adopt function usage and if it can be now removed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=249580

            Bug ID: 249580
           Summary: Evaluate string::adopt function usage and if it can be
                    now removed
           Product: WebKit
           Version: Safari Technology Preview
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ahmad.saleem792 at gmail.com

Hi,

This bug is based on @Darin's comment on PR7827:

https://github.com/WebKit/WebKit/pull/7827#pullrequestreview-1222082977

It is following:

'If this eliminates all uses of the String::adopt function that takes a vector, then that function should also be removed from the String class.'

Quick search shows that it is currently used across various files:


Source/WTF/wtf/URLParser.cpp
Source/WebCore/platform/text/LocaleICU.cpp <--- PR was modifying this file
Source/WTF/wtf/URLHelpers.cpp
Source/WebCore/PAL/pal/text/win/TextCodecWin.cpp
Source/JavaScriptCore/runtime/JSDateMath.cpp
Source/WebKit/UIProcess/Inspector/Mac/RemoteWebInspectorUIProxyMac.mm
...

Just wanted to raise this to get input and also to track it for future purposes.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221219/b36deebb/attachment.htm>