[Webkit-unassigned] [Bug 249024] New: [css-grid] Clean up management of masonry items

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 9 09:05:59 PST 2022


https://bugs.webkit.org/show_bug.cgi?id=249024

            Bug ID: 249024
           Summary: [css-grid] Clean up management of masonry items
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: sgill26 at apple.com

During the initial steps of masonry, we iterate over all the grid items and separate them into different structures to use in different parts of the algorithm. There are 2 main things that can be done to improve the quality of the code:

1.) Instead of storing the items using raw pointers, we should use WeakPtrs/CheckPtrs or std::reference_wrapper 
2.) At the end of the layout we should probably clear these collections so it is obvious we intend not to use them after layout

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221209/c247516c/attachment-0001.htm>


More information about the webkit-unassigned mailing list