[Webkit-unassigned] [Bug 248745] In results.html, links to diffs for tests with periods in the name fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=248745

--- Comment #2 from Philippe Normand <philn at igalia.com> ---
The issue is that for this testName we end up in the "Temporary fix" case for which I have no context. 

    static testPrefix(testName)
    {
        let parts = Utils.splitExtension(testName);
        let prefix = parts[0];
        let remains = parts[2];
        if (remains) {
            if (remains.includes('?'))
                prefix += '_' + remains.split('?')[1]
            else if (remains.includes('#'))
                prefix += '_' + remains.split('#')[1]
        } else if (Utils.splitExtension(parts[0])[1].length > 5) {
            // Temporary fix, also in Tools/Scripts/webkitpy/layout_tests/constrollers/test_result_writer.py, line 115.
            // FIXME: Refactor to avoid confusing reference to both test and process names.
            return testName;
        }
        return prefix;
    }

Utils.splitExtension(parts[0])[1] == '.https' here, so we'd need an additional check, but as I lack the historical meaning of this code, I'm not sure how to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221205/ac5a3e98/attachment-0001.htm>