[Webkit-unassigned] [Bug 248572] AX: Include AXKeyShortcutsValue in accessibilityAttributeNames when there is an aria-keyshortcuts attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=248572

--- Comment #6 from Tommy McHugh <thomas_mchugh at apple.com> ---
(In reply to Andres Gonzalez from comment #3)
> (In reply to Tommy McHugh from comment #2)
> > Created attachment 463819 [details]
> > Patch
> 
> --- a/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
> +++ b/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
> 
> +#ifndef NSAccessibilityKeyShortcutsValue
> +#define NSAccessibilityKeyShortcutsValue @"AXKeyShortcutsValue"
> +#endif
> 
> While naming these constants, please drop the "Value", it doesn't add
> anything to the name, just makes it longer. Also The NSAccessibility names
> have traditionally ended in "Attribute", so if we keep tradition this should
> be:
> 
> +#ifndef NSAccessibilityKeyShortcutsAttribute
> +#define NSAccessibilityKeyShortcutsAttribute @"AXKeyShortcuts"
> +#endif
Sounds good! Updated these to remove value. I don't think we can change the actual attribute name though, its seems to be specced that way https://github.com/web-platform-tests/wpt/pull/36082/files

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20221201/1a43b2ff/attachment.htm>