[Webkit-unassigned] [Bug 244660] New: [git-webkit] Accidental overwrite of pull request with similar branch names in Github

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244660

            Bug ID: 244660
           Summary: [git-webkit] Accidental overwrite of pull request with
                    similar branch names in Github
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com

When searching for pull requests by branch name, the qualifier `head:NAME` matches branches beginning with NAME instead of exact matches. This may cause git-webkit to assume a PR exists for a new branch with similar name to a previous one.

Example:

Last week I pushed https://github.com/WebKit/WebKit/pull/3732, with branch `non-unified-august-26th`. Submitted and merged normally.

Today I tried to submit a new one with branch name `non-unified-august`. The submition ended up finding PR-3732, and overwriting the description of it.

Maybe a fix would be checking for exact head/branch name match when checking whether we have an opened PR? (program/pull_request.py:PullRequest.find_existing_pull_request)

Link to Github docs: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-branch-name

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220901/9b1d52bf/attachment.htm>