[Webkit-unassigned] [Bug 244615] New: Replace WEBKIT2_COMPILATION with BUILDING_WEBKIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244615

            Bug ID: 244615
           Summary: Replace WEBKIT2_COMPILATION with BUILDING_WEBKIT
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at gnome.org
                CC: bugs-noreply at webkitgtk.org
            Blocks: 228250

Trying to reduce more legacy WebKit2 branding, I first wanted to rename WEBKIT2_COMPILATION to WEBKIT_COMPILATION. But that's almost redundant with BUILDING_WEBKIT, which is used in more places. I don't think we need both. We don't need a separate preprocessor definition to distinguish between building Source/WebKit vs. other components of WebKit because Source/WebKit does not have any export macros, and it would be extremely confusing to try to maintain such a distinction anyway. Defining BUILDING_WEBKIT everywhere simplifies things.

Currently it's actually defined separately for each port, only when building Source/WebKit, but this is confusing and annoying as tests often need to include private headers, so it's easier if we move it to a global location.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=228250
[Bug 228250] [GTK4] Change API version from webkit2gtk-5.0 to webkitgtk-5.0
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220831/1af8dc0d/attachment.htm>