[Webkit-unassigned] [Bug 232075] [JSC] Implement Date.prototype.toTemporalInstant()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 31 09:50:06 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=232075

Mikhail R. Gadelha <mikhail at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikhail at igalia.com

--- Comment #5 from Mikhail R. Gadelha <mikhail at igalia.com> ---
Hey Aditi, clang is warning about an off-by-one error here:

DatePrototype.cpp:934:93: warning: implicit conversion from 'long' to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Wimplicit-const-int-float-conversion]
    ASSERT(epochMilliseconds >= std::numeric_limits<int64_t>::min() && epochMilliseconds <= std::numeric_limits<int64_t>::max());
                                                                                         ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mgadelha/tools/WebKit/WebKitBuild/Debug/WTF/Headers/wtf/Assertions.h:363:11: note: expanded from macro 'ASSERT'
    if (!(assertion)) { \
          ^~~~~~~~~
1 warning generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220831/b3bf528d/attachment.htm>


More information about the webkit-unassigned mailing list