[Webkit-unassigned] [Bug 244128] Add experimental feature to disable Bitmap image animations
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 30 14:50:11 PDT 2022
https://bugs.webkit.org/show_bug.cgi?id=244128
--- Comment #33 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #31)
> > Source/WebCore/platform/graphics/BitmapImage.cpp:378
> > + return repetitionCount() && !m_animationFinished && imageObserver() && (imageObserver()->hasPageResumedAnimationWhenSettingEnabled() || !m_disableAnimation || m_allowAnimationWhenSettingEnabled );
>
> Why doesn't the call out to imageObserver do the job of consulting the
> setting and whether animations have been re-enabled? It would be better if
> BitmapImage didn't have to store m_disableAnimation and
> m_allowAnimationWhenSettingEnabled
>
This will work for m_disableAnimation & for checking if page-wide animations are resumed (I'll move those there), but m_allowAnimationWhenSettingEnabled is used if just one image needs to animate, and not the whole page.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220830/9c800645/attachment.htm>
More information about the webkit-unassigned
mailing list