[Webkit-unassigned] [Bug 41063] Media query - width in 'em's doesn't work on zoom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41063

--- Comment #12 from Ahmad Saleem <zlip.792 at gmail.com> ---
I tried to do pull request as Blink in following PR but it does not compile:

https://github.com/WebKit/WebKit/pull/3734

I think it might be due to following of these but I might be completely wrong here:

https://github.com/WebKit/WebKit/blob/cbe5dfe8952e90d8b26a4ee9fc237f6dc91dfd0e/Source/WebCore/css/CSSToLengthConversionData.cpp#L84

https://github.com/WebKit/WebKit/blob/cbe5dfe8952e90d8b26a4ee9fc237f6dc91dfd0e/Source/WebCore/css/CSSToLengthConversionData.cpp#L57

or this case does not looking for zoom:

https://github.com/WebKit/WebKit/blob/cbe5dfe8952e90d8b26a4ee9fc237f6dc91dfd0e/Source/WebCore/css/CSSPrimitiveValue.cpp#L729

______

Since I am not C++ and Programming expert and was just trying. So I want to post my learnings before I close my pull request Thanks!

____

NOTE - I tried following:

return primitiveValue.computeLength<double>(conversionData.zoom());

return primitiveValue.computeLength<double>(conversionData,1,true);

return primitiveValue.computeLength<double>(conversionData, 1.0);

return primitiveValue.computeLength<double>(conversionData,1.0 /* Comment */, true /* Comment */);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220829/3c841d67/attachment.htm>