[Webkit-unassigned] [Bug 120038] input[type=date] with invalid date should return empty string for value IDL attribute instead of the default value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120038

--- Comment #4 from Ahmad Saleem <zlip.792 at gmail.com> ---
(In reply to Ahmad Saleem from comment #3)
> NOTE - I tried doing the change in below Pull Request and noticed following:
> 
> https://github.com/WebKit/WebKit/pull/3516
> 
> 1) Test Case in Chromium / Blink is outdated and you need to get updated
> from Blink / Chromium Github mirror or source.chromium.org
> 
> 2) In the updated test case, they are using "runtimeFlags" rather than
> "settings in below, so this need to be tweak to run in Webkit:
> 
> internals.settings.setLangAttributeAwareFormControlUIEnabled(true);
> 
> 3) Safari / Webkit fail difference tests across different infrastructure but
> do pass few of them as well. It could be "platform" dependent / locale
> dependent cases and investigating them was beyond my expertise.
> 
> 4) This change only fail "test" which is within this Chromium / Blink
> commit, if you do change without test case, it does not fail any existing
> test case and it is currently still in Chromium Source Code. So it is kind
> of fail safe but we cannot land it without test case, so I hate to close my
> pull request.
> 
> Just wanted to share the information for anyone who try to attempt this in
> future. Thanks!

5) In new test case, they have changed the wording for keys to "ArrowUp", which are not supported within Webkit/Github test infrastructure, so they need to be tweaked back to old test case from this "upArrow" otherwise there will be more failures and in some platform, you will get weird outputs.

e.g. on mac-wk, without (5), you will get following on sample test case:

== Up/Down keys ==
FAIL input.value should be 2012-10-29. Was 2012-09-29ArrowUp.
FAIL input.value should be 2012-08-29. Was 2012-09-29ArrowUpArrowDownArrowDown.

But if you tweak it to "upArrow" etc., you get this:

== Up/Down keys ==
FAIL input.value should be 2012-10-29. Was 2012-09-29.
FAIL input.value should be 2012-08-29. Was 2012-09-29.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220827/d28fa811/attachment-0001.htm>