[Webkit-unassigned] [Bug 244128] Add experimental feature to disable Bitmap image animations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #24 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 461861
  --> https://bugs.webkit.org/attachment.cgi?id=461861
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461861&action=review

> Source/WebCore/page/Page.cpp:4032
> +    m_hasUnpausedAnimations = !m_hasUnpausedAnimations;

You're trying to maintain a flag here that reflects the state of all the images in all the subframes. That seems pretty hard: subframes can be created or destroyed, and in each subframe, images can be dynamically added or removed. How can you trust the state of this flag?

> Source/WebCore/page/Page.cpp:4042
> +                    if (auto* cachedBackgroundImage = renderer->style().backgroundLayers().image()->cachedImage()) {

This is only getting the first background layer; CSS backgrounds can have multiple images, so you need to walk the list here. But that list walking code shouldn't live here in Page (put it on a Renderer class).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220825/47745141/attachment.htm>