[Webkit-unassigned] [Bug 244128] Add experimental feature to disable Bitmap image animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 25 12:25:36 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #22 from Joshua Hoffman <jhoffman23 at apple.com> ---
(In reply to Simon Fraser (smfr) from comment #21)
> 
> If these are just for testing (and I think they are), please name them
> `toggleAllAnimationsForTesting()`, `containsAnimatedImagesForTesting()` etc,
> since they are expensive and we don't want to start calling them in
> production code.

In a follow up patch, the intention is that both `toggleAllAnimations` and `containsAnimatedImages` will be used to control page animations. However, they are called very infrequently and only ever when the AnimatedImagesDisabled setting is enabled. Would renaming them to something like `toggleAllAnimationsWhenDisabled` make that more clear? I can also add a check in them to ensure the setting is enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220825/de68c1b0/attachment.htm>


More information about the webkit-unassigned mailing list