[Webkit-unassigned] [Bug 243573] IntersectionObserver intersectionRatio < 1 observed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=243573

--- Comment #7 from Ahmad Saleem <zlip.792 at gmail.com> ---
(In reply to Simon Fraser (smfr) from comment #6)
> diff --git a/Source/WebCore/dom/Document.cpp
> b/Source/WebCore/dom/Document.cpp
> index
> 5d3d20c820a0e9f03642a412ad9aff493bb25ff3..
> 5cd70b074858012e752a5f35cafaa84b97e600d0 100644
> --- a/Source/WebCore/dom/Document.cpp
> +++ b/Source/WebCore/dom/Document.cpp
> @@ -8043,7 +8043,7 @@ static std::optional<LayoutRect>
> computeClippedRectInRootContentsSpace(const Lay
>      if (!intersects)
>          return std::nullopt;
>  
> -    LayoutRect
> rectInFrameViewSpace(renderer->view().frameView().
> contentsToView(snappedIntRect(*rectInFrameAbsoluteSpace)));
> +    LayoutRect rectInFrameViewSpace = LayoutRect {
> renderer->view().frameView().contentsToView(*rectInFrameAbsoluteSpace) };
>      auto* ownerRenderer = renderer->frame().ownerRenderer();
>      if (!ownerRenderer)
>          return std::nullopt;

To fix this - I need to make pull request of this change? I am not super skilled in C++ and still learning GitHub mojo in Webkit. I am happy take it offline on Webkit Slack for any guidance on how to fix this. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220821/cdb4a1f2/attachment-0001.htm>