[Webkit-unassigned] [Bug 119129] Manage the lifetime of DOMTimers with OwnPtr

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119129

Ahmad Saleem <zlip.792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zlip.792 at gmail.com

--- Comment #1 from Ahmad Saleem <zlip.792 at gmail.com> ---
>> Not applied changes to ScriptExecutionContext.cpp:

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/ScriptExecutionContext.cpp#L495

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/ScriptExecutionContext.cpp#L520


>> Not applied changes to ScriptExecutionContext.h:

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/dom/ScriptExecutionContext.h#L239

Plus other lifecycleNotifier changes.

>> Not applied changes to DOMTimer.cpp:

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMTimer.cpp#L161

https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMTimer.cpp#L179

and few other changes.

>> Not applied changes to DOMTimer.h:

Missing ScriptExecutionContext class.

Did some changes here - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMTimer.h#L54

and missing other changes.

>> DOMWindow.cpp changes:

Not done -https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMWindow.cpp#L1842

Not done - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/DOMWindow.cpp#L1867

>> WorkerGlobalScope.cpp does not exist but WindowOrWorkerGlobalScope do:

Only change from 'id' to 'ID" so since all others are not done, I am assuming this wouldn't as well.

________

rniwa at webkit.org - any plan for this or not, since you mentioned bug in Comment 0 is also now fixed, which required this refactoring. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220820/2f5c461b/attachment-0001.htm>