[Webkit-unassigned] [Bug 244128] Add experimental feature to disable image animations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 14:37:19 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=244128

--- Comment #5 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 461738
  --> https://bugs.webkit.org/attachment.cgi?id=461738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461738&action=review

> COMMIT_MESSAGE:3
> +

It has been requested that the Radar number be included underneath the bugzilla URL. If you rerun `git webkit setup`, this will be part of the commit message template.

> Source/WebCore/platform/graphics/Image.h:147
> +    WEBCORE_EXPORT virtual bool isAnimating() const;

Looks like you added an implementation to Image.cpp of this:

bool Image::isAnimating() const
{
    return false;
}

Is that necessary, or can we just keep what exists today but with the WEBCORE_EXPORT added? i.e.:

WEBCORE_EXPORT virtual bool isAnimating() const { return false };

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220819/ef7c307d/attachment.htm>


More information about the webkit-unassigned mailing list