[Webkit-unassigned] [Bug 120037] Name getters on a document can get polluted by elements in shadow DOM

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 19 14:35:15 PDT 2022


https://bugs.webkit.org/show_bug.cgi?id=120037

Ahmad Saleem <zlip.792 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |zlip.792 at gmail.com
         Resolution|---                         |CONFIGURATION CHANGED

--- Comment #1 from Ahmad Saleem <zlip.792 at gmail.com> ---
Element.h:

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L61

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L701

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L707

Element.cpp

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4407

Missing Asserts:

ASSERT(document()->isHTMLDocument());

For:

updateNamedItemRegistration
updateExtraNamedItemRegistration

ADDED Partially or with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4153

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4142

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4125

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4074

TreeScope.h:

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L63

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L135

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L155

TreeScope.cpp:

ADDED with change -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L56

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L132

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L159

ReplaceNodeWithSpanCommand.cpp:

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp#L50

ADDED with no ASSERT -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp#L56

_____

I think this was merge more or less. So I am going to mark this as "RESOLVED CONFIGURATION CHANGED". Please reopen, if needed. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20220819/cae7c5ad/attachment-0001.htm>


More information about the webkit-unassigned mailing list